cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
247 stars 82 forks source link

:art: Restructure container files and materials #577

Closed kks32 closed 4 years ago

kks32 commented 4 years ago
codecov[bot] commented 4 years ago

Codecov Report

Merging #577 into develop will increase coverage by 0.11%. The diff coverage is 99.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #577      +/-   ##
===========================================
+ Coverage    96.74%   96.85%   +0.11%     
===========================================
  Files          114      111       -3     
  Lines        24534    24029     -505     
===========================================
- Hits         23735    23273     -462     
+ Misses         799      756      -43
Impacted Files Coverage Δ
include/containers/map.h 100% <ø> (ø)
tests/particle_cell_crossing_test.cc 99.21% <ø> (ø) :arrow_up:
include/solvers/mpm_base.h 0% <ø> (ø) :arrow_up:
include/materials/newtonian.h 100% <ø> (ø)
include/particles/particle_base.h 100% <ø> (ø) :arrow_up:
include/materials/norsand.tcc 97.76% <ø> (ø)
include/materials/bingham.h 100% <ø> (ø)
tests/materials/linear_elastic_test.cc 100% <ø> (ø)
tests/materials/mohr_coulomb_test.cc 99.91% <ø> (ø)
include/materials/material.tcc 33.33% <ø> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e979852...39283d1. Read the comment docs.

bodhinandach commented 4 years ago

@kks32 shall we wait for #562 to merge first before merging this?

kks32 commented 4 years ago

@bodhinandach Map is technically a container, so I'm being more specific with renaming it to a Vector. We are likely to have other containers, and since we mirror std::vector functions it's easier to call it a Vector than a more generic container.

I'll wait for #562

bodhinandach commented 4 years ago

I am good. Thanks Krishna! We can merge now

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.