cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
247 stars 82 forks source link

Add range to sine function #595

Closed thiagordonho closed 4 years ago

thiagordonho commented 4 years ago

Add range to the definition of a sine function thus allowing for the function to be specified only within this range. The value of the function is equal to zero at times that are outside of this range.

codecov[bot] commented 4 years ago

Codecov Report

Merging #595 into develop will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #595   +/-   ##
========================================
  Coverage    96.82%   96.82%           
========================================
  Files          116      116           
  Lines        24846    24860   +14     
========================================
+ Hits         24055    24069   +14     
  Misses         791      791           
Impacted Files Coverage Δ
include/functions/sin_function.h 100.00% <ø> (ø)
src/functions/sin_function.cc 100.00% <100.00%> (ø)
tests/functions/sin_function_test.cc 96.30% <100.00%> (+0.64%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2283e0...cb5cc8e. Read the comment docs.

kks32 commented 4 years ago

I have the following questions:

  1. Is this to curtail the duration in which the sin function is applied?

  2. Could you provide an example input file in your description?

  3. Is the range function an optional argument?

  4. could we have either just xmin/xmax without specifying the other?