search

cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
243 stars 83 forks source link

NorSand - Change Lode Angle Definition (Cos Rule) #599

Closed ezrayst closed 4 years ago

ezrayst commented 4 years ago

Fix inconsistency in definition of stress as well

codecov[bot] commented 4 years ago

Codecov Report

Merging #599 into develop will increase coverage by 0.00%. The diff coverage is 95.24%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #599   +/-   ##
========================================
  Coverage    96.82%   96.82%           
========================================
  Files          116      116           
  Lines        24846    24848    +2     
========================================
+ Hits         24055    24057    +2     
  Misses         791      791
Impacted Files Coverage Δ
include/materials/norsand.tcc 97.55% <92.86%> (+0.02%) :arrow_up:
tests/materials/norsand_test.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2283e0...fda7766. Read the comment docs.

ezrayst commented 4 years ago

Previous version has stress invariant computed wrongly using compression positive stress notation

ezrayst commented 4 years ago

Need more review. Closing this PR for now.