Closed ezrayst closed 4 years ago
Merging #600 into develop will increase coverage by
0.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #600 +/- ##
===========================================
+ Coverage 96.82% 96.85% +0.03%
===========================================
Files 116 118 +2
Lines 24860 25092 +232
===========================================
+ Hits 24069 24301 +232
Misses 791 791
Impacted Files | Coverage Δ | |
---|---|---|
include/materials/material.h | 100.00% <ø> (ø) |
|
include/materials/material_utility.tcc | 100.00% <100.00%> (ø) |
|
tests/materials/material_utility_test.cc | 100.00% <100.00%> (ø) |
|
tests/functions/sin_function_test.cc | 95.65% <0.00%> (-0.64%) |
:arrow_down: |
src/functions/sin_function.cc | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ce4008e...3fb832a. Read the comment docs.
I think I have addressed all the comments. Now, the namespace is called material
but the file is still called material_utility
.
Throwing some ideas here: material_functions
, material_operations
, materials
(with s) if you want something short.
@kks32, how about the namespace name? should we keep them as material
and the filenames as material_utility
?
I'd go with materials
for namespace and keep the filename as material_utilities.h
?
Understood.
Response to #587. Computations and tests for:
Upcoming work for next PR: