codecov[bot]
commented
4 years ago Codecov Report
Merging #617 into develop will decrease coverage by
0.00%. The diff coverage is97.65%.
@@ Coverage Diff @@
## develop #617 +/- ##
===========================================
- Coverage 97.15% 97.15% -0.00%
===========================================
Files 119 122 +3
Lines 25202 25222 +20
===========================================
+ Hits 24485 24504 +19
- Misses 717 718 +1 | Impacted Files | Coverage Δ | |
|---|---|---|
| include/mesh.tcc | 95.57% <ø> (+0.09%) |
:arrow_up: |
| include/solvers/mpm_base.h | 0.00% <ø> (ø) |
|
| include/solvers/mpm_base.tcc | 69.91% <16.67%> (+<0.01%) |
:arrow_up: |
| include/loads_bcs/constraints.tcc | 97.06% <97.06%> (ø) |
|
| tests/mesh_test_2d.cc | 99.19% <99.19%> (ø) |
|
| include/loads_bcs/constraints.h | 100.00% <100.00%> (ø) |
|
| include/mesh.h | 100.00% <100.00%> (ø) |
|
| tests/mesh_test_3d.cc | 99.16% <100.00%> (ø) |
|
| ... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3bbca6c...276d6b5. Read the comment docs.
kks32
bodhinandach
Describe the PR Refactor velocity constraints on nodes to
Constraintsfile. The mesh test file has been split to 2D and 3D, so only check if applying velocity constraints have moved from mesh to constraints object in the test.Additional context Mesh file is supposed to have only nodes, elements, and particles. Constraints should move to a separate BCs / Loading.