search

cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
243 stars 83 forks source link

Resume bug #624

Closed kks32 closed 4 years ago

kks32 commented 4 years ago

Describe the PR Resume from HDF5 fails on MPI processes because after reading all the particles initially, we don't remove them. This causes a failed pointer issue. This PR reads the HDF5 particle, gets info on the number of rows (particles), and uses this information to accurately resume the process.

Additional context Dynamic load balancing fails when there is significant particle movement. Will open an issue to describe the issue. This PR temporarily disables dynamic load balancing.

codecov[bot] commented 4 years ago

Codecov Report

Merging #624 into develop will increase coverage by 0.00%. The diff coverage is 97.22%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #624   +/-   ##
========================================
  Coverage    97.15%   97.16%           
========================================
  Files          122      122           
  Lines        25222    25241   +19     
========================================
+ Hits         24504    24523   +19     
  Misses         718      718
Impacted Files Coverage Δ
include/mesh.h 100.00% <ø> (ø)
include/mesh.tcc 95.52% <96.00%> (-0.05%) :arrow_down:
include/containers/map.h 100.00% <100.00%> (ø)
include/particles/particle.tcc 94.12% <100.00%> (ø)
include/solvers/mpm_base.tcc 70.02% <100.00%> (+0.11%) :arrow_up:
include/solvers/mpm_explicit.tcc 72.27% <100.00%> (+0.37%) :arrow_up:
tests/node_map_test.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20bba5b...398b2f0. Read the comment docs.