search

cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
245 stars 82 forks source link

:bug: :wrench: Fix incorrectparticle length calculation for GIMP #647

Closed cw646 closed 4 years ago

cw646 commented 4 years ago

Describe the PR For GIMP, the local particle length is required. Prior to this PR, it was calculated by:

local cell length/n_particles in cell

It is now calculated by using:

Length/(npartices^(1/Dimension))

This now gives the correct dimension based length.

Related Issues/PRs Fixes issue #641

Additional context

codecov[bot] commented 4 years ago

Codecov Report

Merging #647 into develop will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #647   +/-   ##
========================================
  Coverage    96.56%   96.56%           
========================================
  Files          122      122           
  Lines        25200    25200           
========================================
  Hits         24332    24332           
  Misses         868      868
Impacted Files Coverage Δ
include/particles/particle.tcc 94.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6533918...b88490b. Read the comment docs.