cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
245 stars 82 forks source link

Fix hardening in NorSand #660

Closed ezrayst closed 4 years ago

ezrayst commented 4 years ago

Describe the PR This fix ensures axissymetric pdstrain as shown and expected.

image

codecov[bot] commented 4 years ago

Codecov Report

Merging #660 into develop will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #660   +/-   ##
========================================
  Coverage    96.55%   96.56%           
========================================
  Files          122      122           
  Lines        25336    25317   -19     
========================================
- Hits         24463    24445   -18     
+ Misses         873      872    -1     
Impacted Files Coverage Δ
include/materials/norsand.tcc 98.80% <100.00%> (+<0.01%) :arrow_up:
tests/materials/norsand_test.cc 100.00% <100.00%> (ø)
tests/cell_test.cc 100.00% <0.00%> (ø)
include/cell.tcc 87.50% <0.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8472fb7...33bf87a. Read the comment docs.

jgiven100 commented 4 years ago

This looks good to solve axisymmetric pdstrain issues previously observed :+1: