search

cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
245 stars 82 forks source link

:hammer: Assign material during initialize particle fix key not found fixes #651 #665

Closed kks32 closed 4 years ago

kks32 commented 4 years ago

Describe the PR Particle initialization with material and state variables fail, as the material is not being properly initialized. This error happens both during MPI transfer and during resume.

Related Issues/PRs

651 was failing with key not found error. This helps fix the issue

Additional context

New implementation uses assign_material function call instead of copying pointer.

kks32 commented 4 years ago

@thiagordonho could you please try your problem again and let me know if you are still facing this issue? Thanks!

codecov[bot] commented 4 years ago

Codecov Report

Merging #665 into develop will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #665   +/-   ##
========================================
  Coverage    96.56%   96.56%           
========================================
  Files          122      122           
  Lines        25265    25266    +1     
========================================
+ Hits         24395    24396    +1     
  Misses         870      870
Impacted Files Coverage Δ
include/particles/particle.tcc 94.36% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0de3ce...9b0d970. Read the comment docs.

kks32 commented 4 years ago

@thiagordonho please run your problem again and let us know if the issue still exists.

kks32 commented 4 years ago

Thank you, Krishna. Is the problem only the material or there might be others?

This seems to be the only issue at the moment, @thiagordonho are you able to run without any issues?