cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
245 stars 82 forks source link

Remove fedora command in partio installation commands #666

Closed ezrayst closed 4 years ago

ezrayst commented 4 years ago

Describe the PR Just cleaning up installation commands to exclude one fedora installation line in ubuntu installation guide.

codecov[bot] commented 4 years ago

Codecov Report

Merging #666 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #666   +/-   ##
========================================
  Coverage    96.56%   96.56%           
========================================
  Files          122      122           
  Lines        25265    25265           
========================================
  Hits         24395    24395           
  Misses         870      870           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0de3ce...acf4b8b. Read the comment docs.

ezrayst commented 4 years ago

Not in the this section

ezrayst commented 4 years ago

Yes, but we have the libraries in the dependencies before right - like the line for Fedora? And if this is for both Ubuntu and Fedora, these lines cannot be used for Ubuntu anyways.

kks32 commented 4 years ago

If someone wants to install partio these are dependencies, so it's good to have them there. Also, our recommended OS is Fedora, so all installation instructions are with respect to Fedora.

ezrayst commented 4 years ago

But isn't it a duplicate of what you have in the dependency installation?

bodhinandach commented 4 years ago

@kks32 One question: these dependencies are not available in Ubuntu: libnsl freeglut freeglut-devel. Do we need anything to install partio in Ubuntu?