search

cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
238 stars 82 forks source link

:fire: :art: Refactor nested namespace - to avoid needing c++17 #670

Closed kks32 closed 4 years ago

kks32 commented 4 years ago

Describe the PR The nested namespace is a supported feature in C++17. However, older versions of Intel doesn't support this feature and has issues on Stampede2. Hence, refactoring this to not need nested namespace.

Related Issues/PRs Discourse issue on compilation on Stampede2 with OpenMP: https://cb-geo.discourse.group/t/compilation-issue-on-tacc-invalid-controlling-predicate/186

codecov[bot] commented 4 years ago

Codecov Report

Merging #670 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #670   +/-   ##
========================================
  Coverage    96.56%   96.56%           
========================================
  Files          122      122           
  Lines        25265    25265           
========================================
  Hits         24395    24395           
  Misses         870      870

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ed027d...ae68d12. Read the comment docs.