search

cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
238 stars 82 forks source link

[Refactor] Adding particles properties #673

Closed bodhinandach closed 3 years ago

bodhinandach commented 4 years ago

Describe the PR Adding container and general functions in node and particle_base for fluid and two-phase particle purposes.

Related Issues/PRs

637, #650, and #654

Additional context Due to the observed performance issue, the current containers and general functions in node and particle_base are added for fluid and two_phase particles without changing the solid_particle. Test should be added later in the PR of fluid and two-phase particles.

codecov[bot] commented 4 years ago

Codecov Report

Merging #673 into develop will decrease coverage by 0.10%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #673      +/-   ##
===========================================
- Coverage    96.66%   96.56%   -0.10%     
===========================================
  Files          123      123              
  Lines        25375    25401      +26     
===========================================
  Hits         24527    24527              
- Misses         848      874      +26
Impacted Files Coverage Δ
include/node.h 100.00% <ø> (ø)
include/node.tcc 88.83% <0.00%> (-7.15%) :arrow_down:
include/node_base.h 100.00% <ø> (ø)
include/particles/particle.h 100.00% <ø> (ø)
include/particles/particle_base.h 100.00% <ø> (ø)
include/particles/particle_base.tcc 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b20da5...c736d44. Read the comment docs.

bodhinandach commented 4 years ago

@ezrayst This is for option (2). The option (3) is the PR #654 itself. As for hdf5 and resume, since the solid particle is untouched here, there will be no problem.

ezrayst commented 4 years ago

Alright, but what about the hdf5 and resume for fluid phase for instance?

bodhinandach commented 4 years ago

Alright, but what about the hdf5 and resume for fluid phase for instance?

This will be implemented in the fluid or two-phase particles in the future PRs.

bodhinandach commented 3 years ago

@kks32 Should we delete this branch and archive refactor/particles?