search

cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
245 stars 82 forks source link

:hammer: vtk statevars is set as an optional argument #687

Closed kks32 closed 4 years ago

kks32 commented 4 years ago

Describe the PR The PR #683 made vtk state vars argument required breaking benchmarks and input files. This PR reverts the vtk_statevars as an optional argument.

Related Issues/PRs

683

Additional context

"vtk_statevars": [
    {
        "phase_id" : 0,
        "statevars": ["pressure", "pdstrain"]
    },
    {
        "phase_id" : 1,
        "statevars": ["pressure"]
    }
]

Once vtk_statevars JSON object is defined in the input file, it has to follow the above format, otherwise it results in an error. This is the expected behavior to tell users that their input file is wrong.

codecov[bot] commented 4 years ago

Codecov Report

Merging #687 into develop will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #687      +/-   ##
===========================================
+ Coverage    96.68%   96.68%   +0.01%     
===========================================
  Files          123      123              
  Lines        25387    25391       +4     
===========================================
+ Hits         24543    24549       +6     
+ Misses         844      842       -2
Impacted Files Coverage Δ
include/solvers/mpm_base.tcc 75.62% <100.00%> (+0.49%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 840405a...59abc7f. Read the comment docs.