search

cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
244 stars 82 forks source link

Increase MPI buffer to avoid errors in sending #697

Closed kks32 closed 4 years ago

kks32 commented 4 years ago

Describe the PR

On domain decomposition, transfer_nonrank_particles gave an error when running on multiple MPI tasks. It resulted in corrupted particle data.

image

The buffer point in MPI_Isend ran out of scope/space. When using a thread-safe MPI_Ibsend instead of MPI_Isend the following error happened. 

Abort(67117313) on node 0 (rank 0 in comm 0): Fatal error in PMPI_Ibsend: Invalid buffer pointer, error stack:

Which clearly shows the error is because of running out of buffer space.

The MPI buffer space is increased in the main function to avoid this error.

Related Issues/PRs

696

codecov[bot] commented 4 years ago

Codecov Report

Merging #697 into develop will increase coverage by 0.00%. The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #697   +/-   ##
========================================
  Coverage    96.69%   96.69%           
========================================
  Files          130      130           
  Lines        25822    25823    +1     
========================================
+ Hits         24968    24969    +1     
  Misses         854      854
Impacted Files Coverage Δ
include/mesh.tcc 82.65% <0.00%> (ø)
include/particles/particle.tcc 91.94% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19570dd...114b497. Read the comment docs.