cb-geo / mpm

CB-Geo High-Performance Material Point Method
https://www.cb-geo.com/research/mpm
Other
244 stars 82 forks source link

Add shear and compression wave velocities to Linear Elastic Material Properties for #692 #705

Closed cgeudeker closed 3 years ago

cgeudeker commented 3 years ago

Describe the PR Add shear and compression wave velocities to linear elastic material properties related to #692 .

Related Issues/PRs Related to #692, specifically Kelvin-Voigt boundary.

Additional context The following gives information that can also be found in the following paper. Kelvin-Voigt boundary elements operate as a dashpot, spring system according to the following equations.

KV_boundary_eqs

Equations for calculating P-wave (c_p) and S-wave (c_s) velocities:

wave_velocities

is the constrained modulus, calculated as

Equations for calculating corresponding spring coefficients:

spring_coeffs

Additionally, constrained modulus and shear modulus were calculated. layer_thickness was the only value that could not be calculated by the already existent material properties.

Input File Format:

P-wave and S-wave velocities are automatically calculated using values already defined in linear elastic properties. The values are then recorded into the JSON material properties object

    properties_["pwave_velocity"] = vp_;
    properties_["swave_velocity"] = vs_;
codecov[bot] commented 3 years ago

Codecov Report

Merging #705 (30ef52e) into develop (4c93b20) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #705   +/-   ##
========================================
  Coverage    96.78%   96.78%           
========================================
  Files          130      130           
  Lines        25882    25899   +17     
========================================
+ Hits         25048    25065   +17     
  Misses         834      834           
Impacted Files Coverage Δ
include/materials/linear_elastic.h 100.00% <ø> (ø)
include/materials/linear_elastic.tcc 100.00% <100.00%> (ø)
tests/materials/linear_elastic_test.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27086f7...30ef52e. Read the comment docs.

cgeudeker commented 3 years ago

@kks32 I updated the PR description. In short though, I felt that a boolean parameter worked better since it is just determining whether or not the P-wave and S-wave properties would be calculated. Alternatively though if we want to be able to input them as well, perhaps overwriting the calculation that would have been made otherwise than I think your approach would make more sense.

kks32 commented 3 years ago

@cgeudeker The boolean doesn't do anything, you can set it to true and not actually define vs or vp. I don't understand what you mean by Alternatively though if we want to be able to input them as well, perhaps overwriting the calculation that would have been made otherwise than I think your approach would make more sense.? Please add the input file example in the PR description

kks32 commented 3 years ago

https://github.com/cb-geo/mpm/blob/c9630b300f18d5cde87945e7f1ae8d1e7040d1cc/tests/materials/norsand_test.cc#L70 Reference for how to get a specific material property

kks32 commented 3 years ago

@jgiven100 Hi Joel if you have some time could you please review this? I'm happy with the changes to calculate shear wave and compression wave velocities in Linear Elastic model