mfontaine218 commented 2 years ago

Describe the PR Added physical time to MPI-parallel VTK outputs so that physical simulation time can be seen in ParaView visualization, .pvd files are created for each attribute with time step included.

Related Issues/PRs Related to issue #727

jgiven100 commented 2 years ago

@mfontaine218 Looks like you'll need to run clang-format to get the circleci checks to pass

shellshocked2003 commented 2 years ago

@mfontaine218, as @jgiven100 pointed out, the build is failing due to file formatting not meeting the repository standard. Running clang-format will automatically adjust the files to the specified formatting, so shouldn't be a hard fix. Please let me know if you have any issues/questions about that.

codecov[bot] commented 2 years ago

Codecov Report

Merging #729 (bd3284d) into develop (adfe6f1) will decrease coverage by 0.02%. The diff coverage is 75.86%.

@@             Coverage Diff             @@
##           develop     #729      +/-   ##
===========================================
- Coverage    96.75%   96.73%   -0.02%     
===========================================
  Files          130      130              
  Lines        25932    25961      +29     
===========================================
+ Hits         25090    25112      +22     
- Misses         842      849       +7

Impacted Files	Coverage Δ
include/solvers/mpm_base.tcc	`77.04% <ø> (ø)`
src/io/vtk_writer.cc	`92.90% <74.07%> (-3.97%)`	:arrow_down:
tests/io/vtk_writer_test.cc	`97.18% <100.00%> (+0.08%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adfe6f1...bd3284d. Read the comment docs.

cb-geo / mpm

Adding Physical Time to VTK Outputs for #727 #729

Codecov Report