applespi: Add keyboard-backlight support.

cb22 / macbook12-spi-driver

WIP input driver for the SPI touchpad / keyboard found in the 12" MacBook (MacBook8,1 + MacBook9,1)

GNU General Public License v2.0

298 stars 103 forks source link

applespi: Add keyboard-backlight support. #31

Closed roadrunner2 closed 7 years ago

roadrunner2 commented 7 years ago

I assume you already started adding this functionality to the driver, but I got impatient and too excited about having the backlight working after you posted your traces in Dunedan/mbp-2016-linux#16 that I went ahead and created this. Feel free to ignore, trash, plunder, or otherwise do what you like with this.

Dunedan commented 7 years ago

Works fine. :+1:

cb22 commented 7 years ago

@roadrunner2 this is great! Confirmed working on my Macbook9,1, so I'm going to go ahead and merge it.

Really oddly, it seems like the SPI issues I was having previously have vanished. No idea what was going on there.

roadrunner2 commented 7 years ago

@cb22 Interesting about the SPI issues vanishing. I suppose that's both good and bad news: good that it's working for you now, but bad in that it's leaving me worried we still have some sporadic issue here and no way to debug it. Oh well, will have to wait and see if anybody else complains of the same problem.

Thanks for merging this and all the other pull requests!