search

cb22 / macbook12-spi-driver

WIP input driver for the SPI touchpad / keyboard found in the 12" MacBook (MacBook8,1 + MacBook9,1)
GNU General Public License v2.0
298 stars 103 forks source link

Formatting cleanup #48

Closed roadrunner2 closed 6 years ago

roadrunner2 commented 6 years ago

Just some basic cleanups. No functional change.

roadrunner2 commented 6 years ago

Added another commit on top here in response to @l1k's comments. It's not a formatting cleanup, but it just refactors the code a bit, so still no functional change.

l1k commented 6 years ago

Just ran this through scripts/checkpatch.pl --strict -f, it only finds this nit:

CHECK: 'seperate' may be misspelled - perhaps 'separate'?
#1289: 
    /* Now, set up the touchpad as a seperate input device */
l1k commented 6 years ago

To mainline, put it somewhere in drivers/input/ (keyboard? misc?), add Kconfig and Makefile entries, add copyright + license header to the file, write a commit message which explains a bit which machines this is for and how it works, add Signed-off-by for all contributors, send it to the list and maintainers, cc everyone who might be relevant.

git only allows a single author unfortunately, that's probably either of Federico or Ronald.

The patch might have to go through the merry-go-round a couple of times, depends on the maintainers, some are lax and some are picky. I've no past experience with the input maintainers.

Once the driver gets merged, it will be a bit more cumbersome to make changes as everything goes through the regular review process on mailing lists, instead of informal pull requests on GitHub.

Let me know if you need help with any of these steps.