search

cb22 / macbook12-spi-driver

WIP input driver for the SPI touchpad / keyboard found in the 12" MacBook (MacBook8,1 + MacBook9,1)
GNU General Public License v2.0
298 stars 103 forks source link

Implement function key #5

Closed roadrunner2 closed 7 years ago

roadrunner2 commented 7 years ago

This was tested on a MBP Late 2016, i.e. with touchbar, so haven't tested the F1-F12 keys. This also means the driver works on these new MBP's (modulo a small hiccup) - many thanks!

cb22 commented 7 years ago

Hey @roadrunner2

Thanks for the pull request; glad to hear the driver works on the newer MBPs too. I'll give it a test to check the F1-F12 keys on my 12" MB, but otherwise looks good to me.

roadrunner2 commented 7 years ago

I just realized one thing: we're not actually sending an event for the function-key itself currently. I'm not sure if the input processing will do anything with it, but I noticed hid-apple.c sends it, so I should probably add that.

roadrunner2 commented 7 years ago

I just updated the patch to also generate the KEY_FN event.

cb22 commented 7 years ago

Great, can confirm everything (keyboard side) works well on my MB 12"