search

cbachhuber / G2GDelay

Glass-to-Glass delay measurement system
Other
9 stars 5 forks source link

Build Arduino sktech in CI #16

Closed cbachhuber closed 2 years ago

cbachhuber commented 2 years ago

Let's see if we can enable a first job that builds the Arduino sketch. Inspiration: https://blog.arduino.cc/2019/11/14/arduino-on-github-actions/

joshua-glazer commented 2 years ago

Forgot to add a comment when I approved it.. I'm not familiar with setting up CI, but the Arduino code compiles after your changes and appears to function the same as before.

joshua-glazer commented 2 years ago

Ah, you could also squash some of your commits to keep the history a bit cleaner if you like.

cbachhuber commented 2 years ago

Forgot to add a comment when I approved it.. I'm not familiar with setting up CI, but the Arduino code compiles after your changes and appears to function the same as before.

Perfect, this is very much expected. CI will try to build the code on every commit on master and on each PR. Consequently, we'll never have non-compiling code in the repo :)

squash some of your commits

Good idea, I'll make 'squash and merge`

image

the default merging strategy in this repo. That yields a clean history on master and all the gory details in the PRs.