search

cbachhuber / G2GDelay

Glass-to-Glass delay measurement system
Other
9 stars 5 forks source link

G2G doesn't display 0.00ms anymore when PT is next to LED #6

Closed joshua-glazer closed 3 years ago

joshua-glazer commented 3 years ago

I noticed that after the latest commits I don't meaure 0.00ms anymore when testing the LED next to the phototransistor.

cbachhuber commented 3 years ago

Which values are you seeing? Something that's consistently close to zero, or something else?

cbachhuber commented 3 years ago

You sent me per email:

So I have it printing 0.0ms again and at the right frequency

Hence I'm closing this issue. Feel free to reopen if I understood that wrong 👍

joshua-glazer commented 3 years ago

I wasn't seeing any values when putting the PT next to the LED actually. In the past, your rising edge detection code would check for either:

And in that version I can see 0.00ms with the PT and LED next to each other. But you removed the second check when you tidied up the Arduino code, and replacing it seems to have fixed the problem. I just didn't get around to creating a PR for the change yet so please reopen the issue :) (seems like I can't do it)