cbaggers / varjo

Lisp to GLSL Language Translator
BSD 2-Clause "Simplified" License
223 stars 23 forks source link

Add implicit ubo/ssbo layout to qualifiers slot #152

Closed mfiano closed 6 years ago

mfiano commented 6 years ago

When a uniform struct is given :ubo or :ssbo without an explicit packing layout, :std-140 is implied in the glsl source. I request that when left out, we explicitly add it to the qualifiers slot so that it can be queried from lisp.

cbaggers commented 6 years ago

Agreed. I'd like to do this in #'make-stage so it can be reviewed before being passed to translate. I wonder what other things we can expand here.

Thanks for the issue report

cbaggers commented 6 years ago

Fixed on feature/remove-qualifiers-from-vars