cbanack / comic-vine-scraper

An add-on script for ComicRack that lets you copy details from Comic Vine into your comic books.
258 stars 48 forks source link

Publishing dates incorrect (adding 2 months) #314

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
DESCRIBE THE PROBLEM:
The scraper is currently not scraping the publishing dates correctly. (So I 
found with a few Spider-Man series)
As far as I can tell the scrapper is adding 2 months to the date and often not 
giving the correct day.

WHAT VERSION OF COMICVINESCRAPER ARE YOU USING?
1.0.63

Original issue reported on code.google.com by orion.d...@gmail.com on 18 Apr 2013 at 3:44

GoogleCodeExporter commented 9 years ago
Can you give me an example or two of specific comics that exhibit this problem?

Original comment by cban...@gmail.com on 18 Apr 2013 at 3:57

GoogleCodeExporter commented 9 years ago
Can this simply be the store date/published date thing that was discussed in 
the forum, and values not being where expected?

Original comment by joaomigu...@gmail.com on 20 Apr 2013 at 9:48

GoogleCodeExporter commented 9 years ago
It might be...hard for me to say without any idea what comic we are talking 
about.

Original comment by cban...@gmail.com on 20 Apr 2013 at 10:07

GoogleCodeExporter commented 9 years ago
It's happening with several spider-man comics (sorry forgot to add that)

superior spider-man
avenging spider-man
amazing spider-man

but i think it's actually affecting all comics

Original comment by orion.d...@gmail.com on 23 Apr 2013 at 7:43

GoogleCodeExporter commented 9 years ago
Ok, I just scraped Superior Spider-man #8, and it seems to scrape correctly.  
It scraped a "Published date" (i.e. what's printed on the cover) of June 2013, 
and an "In Store Date" (what ComicRack calls the "Released Date") of April 17, 
2013.  This matches with what I see on the Comic Vine website.

Perhaps you are only noticing the published date when you look at your Comic in 
ComicRack? In order to see the Released Date as well, you have to turn on the 
"Catalog Tab" in ComicRack.  I can't quite remember where it is, but there is a 
preference in ComicRack for turning that on.

Original comment by cban...@gmail.com on 24 Apr 2013 at 9:26

GoogleCodeExporter commented 9 years ago
I'm aware of the difference between "Published date" and "Released Date" and I 
am referring to the "Published date".

I just scraped it again. Under "Summary" it is providing the correct date 
(April 17 2013), but under "Details" is giving: "Year: 2013 | Month: 6 | Day: 
17".

This is the date used by CR and that is what I meant with "adding 2 months"

Original comment by orion.d...@gmail.com on 25 Apr 2013 at 12:49

GoogleCodeExporter commented 9 years ago
Well, the thing is, both these dates are 'correct', and both are used by 
ComicRack.  The published date for this comic really is 2 months later than the 
release date.  Check the Comic Vine page if you don't believe me (it's under 
"Issue Details"):

http://www.comicvine.com/superior-spider-man-8-troubled-mind-part-two-proof/4000
-397550/

When I scrape Superior Spider-Man #8, it puts the published date of 2013/6 
under the "Summary" tab, and also in the Month and Year fields of the "Details" 
tab.  It puts the released date (2013/4/17) in the Released field of the 
"Catalog" tab.

As far as I've been told, these are the places where the published and released 
dates are supposed to go in ComicRack.  

Is this what's happening for you, or are you seeing something different?

Original comment by cban...@gmail.com on 27 Apr 2013 at 4:19

GoogleCodeExporter commented 9 years ago
I am seeing something different, like I said earlier.

There's a 2 month difference between the dates under the "Summary" tab 
(17-4-2013) and the "Details" tab (2013/6/17).

I used Superior Spider-Man #8 as an example here, but it's the same with all my 
(Marvel) comics.

Original comment by orion.d...@gmail.com on 1 May 2013 at 5:32

GoogleCodeExporter commented 9 years ago
Could it have something to do with the European date format that my PC uses?

i.e. dd-mm-yyyy instead of mm/dd/yyyy

Original comment by orion.d...@gmail.com on 1 May 2013 at 5:36

GoogleCodeExporter commented 9 years ago
Hmmm...well that's a bit strange...it sounds like ComicRack is displaying the 
Released date in your summary tab instead of the the Published date.  Perhaps 
this is a very recent change in ComicRack (I am a version behind right now.)  

Regardless, the scraper does not populate the contents of the Summary tab 
separately, it just sets two dates in a ComicRack ComicBook object, and then 
ComicRack decides what to do with them after that.   So this may be a bug for 
cYo.

(I don't think it would have anything to do with your date format, but it's 
worth mentioning that if you bring this to cYo's attention.)

Original comment by cban...@gmail.com on 1 May 2013 at 6:00

GoogleCodeExporter commented 9 years ago
I do have the newest version so that could have something to do with it

Original comment by orion.d...@gmail.com on 2 May 2013 at 6:08

GoogleCodeExporter commented 9 years ago

Original comment by cban...@gmail.com on 19 May 2013 at 12:38