cbanack / comic-vine-scraper

An add-on script for ComicRack that lets you copy details from Comic Vine into your comic books.
258 stars 48 forks source link

Scraper putting additional info in title field #351

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
DESCRIBE THE PROBLEM:
After scraping, a comic's title field contains a string of the form <Series 
Name> #<issue number> - <Title> instead of just <Title>. This appears to happen 
with all titles both old and new releases.

WHAT STEPS WILL REPRODUCE THIS PROBLEM? (Please include the exact name of
the eComic book that you were trying to scrape, if possible.)
1. Successfully scrape a comic (Cable and X-Force 18, for example)
2. View Title field of scraped book (Cable and X-Force #18 - Vendetta Part 1)

WHAT VERSION OF COMICVINESCRAPER ARE YOU USING?
1.0.71 (also happened in 1.0.70)

PLEASE PROVIDE ANY ADDITIONAL INFORMATION THAT MAY BE OF USE
Probably a result of the same API change that caused a need for 1.0.71

Original issue reported on code.google.com by vegas.jo...@gmail.com on 30 Jan 2014 at 1:12

GoogleCodeExporter commented 9 years ago
Honestly not a Low priority, in my opinion. It's a basic and essential reason 
to have the plugin.

Original comment by danlit...@gmail.com on 30 Jan 2014 at 1:30

GoogleCodeExporter commented 9 years ago
Really?  Not having the series name in the title is a "basic and essential 
reason" to have the plugin?  So, like, if I can't figure out a way to convince 
the ComicVine guys to stop including it, we've all lost one of the main reasons 
for the plugin's existence?

Are you sure this isn't just a small detail that you don't happen to like?

Original comment by cban...@gmail.com on 30 Jan 2014 at 1:45

GoogleCodeExporter commented 9 years ago
Oh dude, not at all, though I do realize I sounded pretty curt and schmucky. 
Apologies for that. Of course it's not a reason to drop the plugin. But you 
have to admit -- that field is pivotal to enough users' organization that there 
other plugins built around it (e.g. Story Arc). Didn't mean to pile on the 
pressure, I see you're on CV's forum getting to the bottom of API changes. No 
hard feelings?

Original comment by danlit...@gmail.com on 30 Jan 2014 at 2:17

GoogleCodeExporter commented 9 years ago
I think its a pretty high priority for me personally. But with the current 
shenanigans happening with the API it's unclear if this is going to change 
again in the coming days, or be a permanent change. So it's probably a low 
priority for development given the inherent lack of clarity about what's going 
to happen with CV's API. 

If this does end up being something CV stays with permanently it'd probably be 
fairly simple to add an option for removing the first part of the string before 
writing it into the comics tag.

Original comment by vegas.jo...@gmail.com on 30 Jan 2014 at 2:46

GoogleCodeExporter commented 9 years ago
Yes, I can (and will) fix this problem if ComicVine doesn't do anything about 
it.

I've posted information for them about it here:

http://www.comicvine.com/forums/bug-reporting-2/api-returns-too-much-information
-in-issue-resource-1532864/

Original comment by cban...@gmail.com on 30 Jan 2014 at 3:24

GoogleCodeExporter commented 9 years ago
Wow. That was fast. This issue is already fixed in CV's API and scraped comics 
now pull down just the title. So you can probably close this issue.

Original comment by vegas.jo...@gmail.com on 30 Jan 2014 at 4:22

GoogleCodeExporter commented 9 years ago
Wow, I guess they're working late tonight!

Original comment by cban...@gmail.com on 30 Jan 2014 at 4:45