cbanack / comic-vine-scraper

An add-on script for ComicRack that lets you copy details from Comic Vine into your comic books.
258 stars 48 forks source link

Handle Comics number 1900-2099 better #389

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There's some optimization in the filename parsing that tries to recognize 
numbers that are years (i.e. 1900-2099).  Unfortunately, some comics actually 
have issue numbers in this range, and you end up having to use a regex setting 
to bypass that problem:

http://comicrack.cyolito.com/forum/32-news-and-announcements/33534-comic-vine-sc
raper?start=490#39930

e.g. none of the following parse properly by default, but maybe they could:

The Beano 1960 [1980-02-09] (TGMG).zip
The Beano #1960 [1980-02-09] (TGMG).zip
The Beano 1960 (1980-02-09) (TGMG).zip

Original issue reported on code.google.com by cban...@gmail.com on 12 Jul 2014 at 8:36

GoogleCodeExporter commented 9 years ago
May be related to issue #395.

Original comment by cban...@gmail.com on 19 Aug 2014 at 7:16

GoogleCodeExporter commented 9 years ago
Unfortunately, we can't just stop detecting "year-like" numbers in filenames.  
There are many series that actually use years as part of their titles, so it's 
important that the scraper can recognize these situations and not interpret 
those years as issue numbers.

I have, however, changed the scraper to understand that numbers that start with 
'#' are always issue numbers, even if they look like years.   This change is in 
version 1.0.86.

Original comment by cban...@gmail.com on 11 Nov 2014 at 11:24

GoogleCodeExporter commented 9 years ago

Original comment by cban...@gmail.com on 11 Nov 2014 at 11:24