cbanack / comic-vine-scraper

An add-on script for ComicRack that lets you copy details from Comic Vine into your comic books.
255 stars 48 forks source link

Books numbered with leading 0's aren't always found correctly #403

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
DESCRIBE THE PROBLEM:
When doing an initial match to find the right series, annuals do not show the 
proper cover in the Choose a Comic Book Series form, though the right series is 
selected and the issue number is available.

WHAT STEPS WILL REPRODUCE THIS PROBLEM? (Please include the exact name of
the eComic book that you were trying to scrape, if possible.)
1. Scrape an annual with a number other than 1
2. The Choose a COmic Book Series form shows issue 1

WHAT VERSION OF COMICVINESCRAPER ARE YOU USING?
1.0.84

PLEASE PROVIDE ANY ADDITIONAL INFORMATION THAT MAY BE OF USE

Original issue reported on code.google.com by bmen...@gmail.com on 30 Jan 2015 at 3:57

GoogleCodeExporter commented 9 years ago
I just gave this a try with some annuals, and it seems to display the proper 
cover as long as the issue number is available in the filename in a form that 
is recognizable to the scraper.

That's what I would expect, since the scraper doesn't really treat annuals 
differently than regular comics.

Perhaps there is an error in the Comic Vine database, or maybe the scraper is 
not recognizing the issue number in your comic book's filename?

If you tell me the exact filename of the comic with which you're seeing this 
problem, I can look into it more closely.

Original comment by cban...@gmail.com on 30 Jan 2015 at 4:19

GoogleCodeExporter commented 9 years ago
I figured out what's happened... many of my annuals have book.Number="05" 
instead of "5".  when I set it to 5 and rescraped, it showed the right issue.  
So the lookup doesn't like leading 0s (though it does scrape properly once you 
select the series)

Original comment by bmen...@gmail.com on 31 Jan 2015 at 6:07

GoogleCodeExporter commented 9 years ago
OK, that should be easy to fix...thanks for letting me know. 

Original comment by cban...@gmail.com on 31 Jan 2015 at 7:13