search

cbanack / comic-vine-scraper

An add-on script for ComicRack that lets you copy details from Comic Vine into your comic books.
243 stars 47 forks source link

ANDing search terms now breaks search #453

Closed cbanack closed 6 years ago

cbanack commented 6 years ago

The fix for issue 349 is no longer needed; that is, the scraper should not AND all of the user's search terms together anymore.

As is explained here, the ANDing the search terms in not necessary with ComicVine's new search engine, and in fact it breaks searches for hyphenated terms like Golden-age or Spider-man.

cbanack commented 6 years ago

Fixed in 1.0.94.

grimble65 commented 6 years ago

Downloading the latest version (1.0.94) only gives a "zip" file but no "crplugin" can be found anywhere in the package.

cbanack commented 6 years ago

You're probably downloading the source code from github (which is packaged up in a zip file).

The crplugin file is in the same place where you originally got it: on the Comic Vine Scraper homepage, which is at https://cvs.xanatos.ca/.

grimble65 commented 6 years ago

Just tried to download it from the Scraper homepage and got the same thing, "zip" file.

From: Cory Banack notifications@github.com Sent: Saturday, February 10, 2018 6:11 AM To: cbanack/comic-vine-scraper Cc: grimble65; Comment Subject: Re: [cbanack/comic-vine-scraper] ANDing search terms now breaks search (#453)

You're probably downloading the source code from github (which is packaged up in a zip file).

The crplugin file is in the same place where you originally got it: on the Comic Vine Scraper homepage, which is at https://cvs.xanatos.ca/.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/cbanack/comic-vine-scraper/issues/453#issuecomment-364644160, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVqZQ9eAoe6tFNnxiEpINhwE1Bq_mTdHks5tTXltgaJpZM4SAyBx.