search

cbanack / comic-vine-scraper

An add-on script for ComicRack that lets you copy details from Comic Vine into your comic books.
243 stars 47 forks source link

Scraper doesn't find comics with 'or' in the title. #458

Closed cbanack closed 5 years ago

cbanack commented 5 years ago

Comic Vine's search API has become lot more specific about requiring words like 'of' and 'and', so the fact that the scraper strips these words out of searches is no longer improving search results. Quite the opposite in fact.

First reported here, and in several subsequent responses to that post.

cbanack commented 5 years ago

So a little bit of investigation shows me that the new Comic Vine search API is actually a lot more robust than the old one was.

But there's a big chunk of code in the scraper that secretly changes the search terms that you enter, in an effort to make up for a lot of deficiencies in the old Comic Vine search API. That scraper code is just not necessary anymore. Worse than that -- it actively trips up the new search API, which is causing many of the search-related problems that have recently been reported in the ComicRack forum.

So I've removed this unneeded code from the scraper. All search terms are now sent directly to Comic Vine with little or no modification, and the results should be a lot better now. Plus, if Comic Vine continues to improve their search engine, the scraper will now inherit those improvements automatically.