search

cbanack / comic-vine-scraper

An add-on script for ComicRack that lets you copy details from Comic Vine into your comic books.
243 stars 47 forks source link

Update utils.py #464

Closed namanix closed 4 years ago

namanix commented 4 years ago

Forcing TLS1.2 so that ComicVine accepts the scraper again

namanix commented 4 years ago

Also made a issue for this problem. See issue: https://github.com/cbanack/comic-vine-scraper/issues/463

henningBunk commented 4 years ago

Awesome! Thanks for the fix. Wanted to use the scraper yesterday after years of abstinence and thought I was doing something wrong. Nice to see that there are still updates on it ❤️

spynotebook commented 4 years ago

I updated to the new scraper but I am still getting an unexpected error. The log shows it still has to do with TLS1.2 because I see this:

Caught AttributeError: 'type' object has no attribute 'Tls12'

Any ideas?

cbanack commented 4 years ago

What version of .net is installed on your computer? I bet you're using an older version that doesn't support TLS 1.2, so if you update to a newer version of .NET then it will work.

On Wed, 11 Sep 2019, 6:23 pm spynotebook, notifications@github.com wrote:

I updated to the new scraper but I am still getting an unexpected error. The log shows it still has to do with TLS1.2 because I see this:

Caught AttributeError: 'type' object has no attribute 'Tls12'

Any ideas?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cbanack/comic-vine-scraper/pull/464?email_source=notifications&email_token=ABVO2SSFXE77P6QNREP3A3TQJGDZRA5CNFSM4IVLJG4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QIW5Y#issuecomment-530615159, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVO2SUDXKMAUZL3FQBNVK3QJGDZRANCNFSM4IVLJG4A .

spynotebook commented 4 years ago

I’m sure that’s it. I use comic rack on a win 7 virtualbox on Ubuntu. I started updates about an hour ago. I almost never run them because I only use this this one app.

Sent from my iPad

On Sep 11, 2019, at 9:19 PM, Cory Banack notifications@github.com wrote:

What version of .net is installed on your computer? I bet you're using an older version that doesn't support TLS 1.2, so if you update to a newer version of .NET then it will work.

On Wed, 11 Sep 2019, 6:23 pm spynotebook, notifications@github.com wrote:

I updated to the new scraper but I am still getting an unexpected error. The log shows it still has to do with TLS1.2 because I see this:

Caught AttributeError: 'type' object has no attribute 'Tls12'

Any ideas?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cbanack/comic-vine-scraper/pull/464?email_source=notifications&email_token=ABVO2SSFXE77P6QNREP3A3TQJGDZRA5CNFSM4IVLJG4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6QIW5Y#issuecomment-530615159, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVO2SUDXKMAUZL3FQBNVK3QJGDZRANCNFSM4IVLJG4A .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.