search

cbanack / comic-vine-scraper

An add-on script for ComicRack that lets you copy details from Comic Vine into your comic books.
243 stars 47 forks source link

Scraper reporting cannot connect to comicvine #471

Closed Krandor1 closed 4 years ago

Krandor1 commented 4 years ago

Comicvine was having issues earlier today but is back up and API appears to be working but the scraper is still reporting the comicvine database could not be reached. They may have changed something... again.

DrTobogganMD commented 4 years ago

Reporting the same.

duckpuppy commented 4 years ago

After running some tests, it looks like they've blocked the ComicVineScraper user agent, or at least changing the UA in the code makes the plugin work again. Not sure if that's intentional or not.

cbanack commented 4 years ago

Yeah, I'm guessing they did some kind of security update that causes their servers to be pickier about user agents. Whatever it is, it definitely does not like Comic Vine's highly irregular custom user agent string, so I've removed it. It wasn't really doing anything anyhow.

The fix will be in CVS 1.0.100, which will be available soon.

Krandor1 commented 4 years ago

Thanks cbanack. With the comicrack forums being down is this the best way to let you know of issues like this by opening a github issue?

cbanack commented 4 years ago

Definitely.

Krandor1 commented 4 years ago

Perfect, Thanks for all your work and quick responses.

duckpuppy commented 4 years ago

Absolutely, thanks for the quick response to the problem!

faethon commented 4 years ago

Thanks for the fix! Great work

bradleybowman commented 4 years ago

@cbanack

I downloaded the latest release, and tried to update the plugin. ComicRack did its restart, but still showed v1.0.99. I uninstalled the extension (and in the process, Library Organizer too somehow..).

A fresh install of v1.0.100 prompts for restart, but isn't installed after the restart. A fresh install of v1.0.99 works. Are there any logs/system info that I can send you?

I'm assuming it's working properly for others, so I don't want to waste your time if it's an isolated issue (I'm a rather infrequent user overall, but appreciate the work you've done!)

cbanack commented 4 years ago

@bradleybowman

There's a long-standing bug in ComicRack where if you run the Scraper, and then update the Scraper, the update won't install properly. Sounds to me like that's what you're seeing. The easiest thing to do is to immediately install the scraper a second time if it looks like it didn't get installed after the first time.

More precisely, you need to fully shut down ComicRack, re-start it, then immediately install the latest version of the scraper before doing anything else. (Installing the scraper twice in a row will accomplish this.)

bradleybowman commented 4 years ago

@cbanack

With v1.0.99 installed, and following your method exactly, I was able to get the update to v1.0.100 to complete. I had not run the scraper prior to attempting the first install, so I'm not sure what got me stuck in that state.

At any rate, that resolves it. Apologies for re-reporting a known issue, I should've used the search first.

tdisalvo commented 4 years ago

Many thanks for keeping this up. Do you have a Paypal for donations?

cbanack commented 4 years ago

Yes I do:

https://github.com/cbanack/comic-vine-scraper/wiki/Support-the-Project

But these days I am basically just "keeping the lights on" with this project, so I'm not really expecting any donations. Your thanks is worth a lot, though.