cbandera / rosparam_handler

An easy wrapper for using parameters in ROS
Other
47 stars 26 forks source link

Fix wrong error message #53

Closed artivis closed 6 years ago

artivis commented 6 years ago

Do not print error message while retrieving a param with default value.

Fix #47 .

beetleskin commented 6 years ago

Is this going to be merged and deployed anytime soon?

Btw, I get the error when I try to instantiate the param struct manually:

ros::NodeHandle pnh("~");
my_package::MyNodeParameters params(pnh);
params.fromParamServer();

Is there a better way of doing it, maybe withouth NodeHandle? I just want to get the struct with the default values.

artivis commented 6 years ago

Indeed this has been pending for a while now, my bad. I'll try to take care of it this weekend :+1:.

The current API does not offer the possibility to instantiate the default values without a NodeHandle. However I think this would be fairly doable, again I'll see what I can do over the weekend.

artivis commented 6 years ago

@beetleskin FYI I will wait some more changes before releasing again (hopefully #37) as the issue this PR fixes is annoying but not critical.

Notice that #37 also initializes parameters with default value at construction time cutting the need from calling params.fromParamServer() to use them :

my_package::MyNodeParameters params(ros::NodeHandle("~"));
my_var_with_default = params.my_var_with_default;

I'll evaluate later the need & implications of a NodeHandle-free constructor...

beetleskin commented 6 years ago

seems legit, thanks!

beetleskin commented 6 years ago

any release date in sight here? :)

beetleskin commented 6 years ago

.. not?

artivis commented 6 years ago

Hi there, I'm currently on vacation. Ill take care of releasing it in a couple weeks, after merging #56. Sorry for the late answer / delay.

artivis commented 6 years ago

@beetleskin FYI release 0.1.4 is on the way for Indigo/Kinetic & Lunar :+1:.