cbandera / rosparam_handler

An easy wrapper for using parameters in ROS
Other
47 stars 26 forks source link

Simplified .params file #65

Open lucascoelhof opened 5 years ago

lucascoelhof commented 5 years ago

Hi all,

First of all, thanks for making this library available!

I would like to propose a simplified way of defining the .params file. Essentially, the current .params file is a Python file, which makes the process of managing metaconfigurations and auto-generation complicated. I created the concept of a metaconfig file, which describes all arguments for the add function. I've also changed the add function to allow positional and keyword args. After these modifications, the .params file is much simpler.

I've done some test on my forks and they work fine. Please feel free to test it using my repos, here: https://github.com/lucascoelhof/rosparam_handler https://github.com/lucascoelhof/rosparam_handler_tests

Do you think this modification is relevant? If yes, how could we make the transition smooth for everyone?

Best regards

artivis commented 5 years ago

Hi @lucascoelhof, Thanks for your interest in this project.

While your proposal seems interesting in that the .params file looks simpler to setup, I do not think that it is suited for this particular package. The original design is meant to be as close as possible to the dynamic_reconfigure for the reason that it makes it very easy for users to transition their dynamic_reconfigure's .cfg files to a rosparam_handler's .params file.

I am going to leave this issue open so that people interested in your work may find it and discuss it, however I will mark it as wontfix for the moment.