search

cbandera / rosparam_handler

An easy wrapper for using parameters in ROS
Other
47 stars 26 forks source link

Noetic release #68

Open destogl opened 4 years ago

destogl commented 4 years ago

Are you planning to do noetic release at some point?

artivis commented 4 years ago

Thanks for the reminder. I sure will release it in Noetic, but there is likely some Python 2 -> 3 port to do first. I'll have a look asap :+1:.

destogl commented 4 years ago

I added the repository in my CI here and got some strange error, probably python 2 -> 3 error

artivis commented 4 years ago

probably python 2 -> 3 error

Yep looks like it.

jarvisschultz commented 3 years ago

I was just trying to build this on Noetic, and ran into a few issues that I think I was able to sort out. See the python3_noetic_conversion.jas branch on my fork. To release, these changes would either need to be updated to support Python 2 and 3 simultaneously, or the repo would have to adopt a Noetic and newer branching strategy as described in the ROS Python 2->3 Migration Guide. Happy to help if @artivis can take the lead on suggestions for how to PR.

artivis commented 3 years ago

Hi @jarvisschultz, Thanks for taking a shot at the migration! I'm afraid I won't have time to take a look before next week but at first glance I'd say I'm fine with having a separate noetic branch.

malban commented 3 years ago

A noetic release would be great. @jarvisschultz's fork seems to work fine me.

130s commented 3 years ago

I'd vote for a separate branching given the chance of needing maintenance in the future may be slim (last commit on the main branch was back in 2018), and the life of the versions that depend on Python2 is known to end with a fixed term (ROS Melodic, the last LTS with Python2 support, will EoL in 2023).

robo-jordo commented 1 year ago

@artivis Any update on a noetic release here using the fork from @jarvisschultz ?