Open stamminator opened 5 years ago
Hi there,
Thanks for the feedback. The plugin doesn't do anything more than validate the user has valid credentials in the specified domain(s) if that feature is used. In order to do what you're asking, the user would need to contain the immutable identifier and it be stored. I would expect a new email address to produce a new user based on the way it is written.
My use of osTicket is for one client, with a low user base who won't care about ticket history. I am not inclined to enhance the plugin beyond what it is doing as of now. If it were me, I would probably update the tables when I updated the email address. You're welcome to fork it, though and make the enhancement.
Hello,
First of all, thanks for making this and open-sourcing it. It's working well for us in testing.
If a user creates their account through this plugin by signing into their Office 365, their email address is stored both in the
ost_user_account
table'susername)
column and also as the default record in theost_user_email
table. My concern is for those occasions where a user has their Office 365 administrator change their account's email address. This is typical for name changes, such as an employee getting married and changing their last name, then updating their email address to match.How does this plugin handle that upon the first login with the new email address? Does it change the email addresses stored in osTicket's database, or does it treat it as a new user? If the latter is the case, which update scripts need to be run on the osTicket side to get those email addresses in sync so that a duplicate account scenario doesn't arise?
Side note: you should consider creating a pull request to add this great plugin to the official https://github.com/osTicket/osTicket-plugins repo so others can find it. I would not have chosen osTicket as our help desk solution if it weren't for your plugin, and I bet other people are in the same boat.