cbbfcd / react-native-lightbox

Images etc in Full Screen Lightbox Popovers for React Native
MIT License
63 stars 27 forks source link

features for v1.0.0 #3

Open cbbfcd opened 3 years ago

cbbfcd commented 3 years ago

Inherit the original author's intention and continue to improve:

Must have

dariuscosden commented 3 years ago

That's quite the undertaking. Would love to see this complete :D

cbbfcd commented 3 years ago

Welcome!

dongdyang commented 3 years ago

save image feature?

cbbfcd commented 2 years ago

If you happen to need the ability to use this warehouse, you can stay and build it together, welcome!

demedos commented 2 years ago

Hi, thank you for keeping this library up to date. The readme states that v0.8.9 should remove the Navigator dependency, but I don't see any branch or tag related to it. Do you have an estimated release date?

Thank you

demedos commented 2 years ago

FYI on Android 10+ there's no need to provide a navigator, it works anyway

cbbfcd commented 2 years ago

FYI on Android 10+ there's no need to provide a navigator, it works anyway

thx~

hellotreedigital commented 2 years ago

Please Support for gallery mode

cbbfcd commented 2 years ago

Please Support for gallery mode

we can custom our gallery like in demo, but it's so good, if we can use a props, like mode: 'gallery', auto support it !

jforaker commented 2 years ago

Seems like orientation change should be high on the list. I wanted so bad to use this lib but the first thing i checked was a device rotation, and it wasn't pleasant. Seems like you could get most of the way there by changing out the old way:


// from this

const { width, height } = Dimensions.get('window')

// to this

const { width, height } = useWindowDimensions()

The latter is reactive instead computed once on load.

demedos commented 2 years ago

Please note that there is still an open issue with useWindowDimensions returning swapped dimensions in some cases. See https://github.com/facebook/react-native/issues/29290