cbc-univie / transformato

Set up relative free energy calculations using a common scaffold
https://cbc-univie.github.io/transformato/
MIT License
22 stars 6 forks source link

Cleaning up the test functionalities #54

Closed JohannesKarwou closed 2 years ago

JohannesKarwou commented 2 years ago

Description

We should clean up, our tests, and make sure, that all of them run on every system

Todos

To Check

Think about a better solution here:

is there a reason why this is preferred to atom.GetSymbol() == 'H? It would also be true for He, right?

one solution might be the use of a if else function

_Originally posted by @wiederm in https://github.com/wiederm/transformato/pull/48#discussion_r885247348_

Questions

Status

codecov-commenter commented 2 years ago

Codecov Report

Merging #54 (3a061e7) into master (852ff5d) will not change coverage. The diff coverage is n/a.

JohannesKarwou commented 2 years ago

First suggestion on how we could structure the repository:

│   README.md
│
└───data
│   │   **toppar**
│   │   system1
│   └───ligand
│   └───complex
│   │   system2
│   │   ...
│   │
└───transformato
│   │   mutate.py
│   │   ...
│   └───tests
│   │  │   test_misc.py
│   │  │   ...
└───docs
JohannesKarwou commented 2 years ago

For 2-Methylindol and 2-Methylfuran there is no folder in the data folder

wiederm commented 2 years ago

superceeded by #77