search

cbcrc / knockout-dragula

Simple binding for Knockout.js to add drag and drop functionality to observableArrays using dragula
13 stars 6 forks source link

Latest knockout 3.5.0 broke this package #15

Open martonx opened 5 years ago

martonx commented 5 years ago

Hi,

Latest knockout 3.5.0 has some foreach optimalizations, which broke knockout-dragula plugin.

https://github.com/knockout/knockout/releases/tag/v3.5.0-beta check second point from foreach performance tune. So ko.options.foreachHidesDestroyed = true can solve the issue, but it would be great, if this wonderful plugin get an update for latest knockout.

laurentlbm-rc commented 5 years ago

I tried the example with Knockout 3.5.0 and it works. Which feature is broken? Could you provide a sample?