search

cbdevnet / midimonster

Multi-protocol control & translation software (ArtNet, MIDI, OSC, sACN, ...)
https://midimonster.net/
BSD 2-Clause "Simplified" License
506 stars 50 forks source link

sACN universe list in discovery messages uses incorrect byte ordering #142

Open alphajbravo opened 5 months ago

alphajbravo commented 5 months ago

When constructing the universe list for an sACN discovery message, the universe numbers are not translated to the correct byte order for the protocol. It looks like memcpy is used to load the PDU data section, which skips the required htobe16 translation step.

https://github.com/cbdevnet/midimonster/blob/811592c8190d12c6c7affa5772db3be30ba941e9/backends/sacn.c#L535

cbdevnet commented 5 months ago

Good catch, will try to find time to look into this