search

cbdevnet / midimonster

Multi-protocol control & translation software (ArtNet, MIDI, OSC, sACN, ...)
https://midimonster.net/
BSD 2-Clause "Simplified" License
499 stars 48 forks source link

sACN backend refuses to transmit universe 0 #22

Closed cbdevnet closed 5 years ago

cbdevnet commented 5 years ago

0 is noted in the backend documentation as a valid universe specification, but https://github.com/cbdevnet/midimonster/blob/master/backends/sacn.c#L576 checks whether the universe is non-zero.

cbdevnet commented 5 years ago

According to the spec, section 6.2.7:

Universe values shall be limited to the range 1 to 63999. Universe value 0 and those between 64000 and 65535 are reserved for future use.

So the implementation is correct, the documentation will have to be updated