search

cbeer / devise-guests

fake 'em until you make 'em
MIT License
130 stars 31 forks source link

Defining the logging_in callback when the controller loads #19

Closed davidkus closed 7 years ago

davidkus commented 9 years ago

From what I've been able to tell, the include block (where the callbacks were being defined) was always being run before define_concern_callbacks, and so DeviseGuests::Controllers::Helpers.callbacks was always nil and no callbacks were being defined.

Defining the callback when the controller loads seems to fix all of the issues I've been having with the callbacks not being defined.

Do we need to define_callbacks whenever the module is included, or will it be OK to just define them on_load ?

FocusedWanderer commented 5 years ago

just found this & realized the pull request wasn't merged & was just closed - this code definitely fixes my problems, so curious if there is a reason it didn't get merged

davidkus commented 5 years ago

@FocusedWanderer to be honest, I had this opened for almost 2 years and hadn't gotten a response, so I closed it 2 years ago when I was cleaning up my repos / open PR list.

Feel free to open your own PR with these code changes and try your luck 😉

FocusedWanderer commented 5 years ago

maybe @jcoyne can help? (noticed he posted most recent release just last month) - I think https://github.com/cbeer/devise-guests/issues/17 is also fixed by this PR.