Raise an error when a critical system call fails

cbeer / engine_cart

Rake tasks to generate test applications for Rails Engines

MIT License

18 stars 16 forks source link

Raise an error when a critical system call fails #67

Closed no-reply closed 7 years ago

no-reply commented 7 years ago

If we fail a system call when generating the test app, we need to fail the task. This also adds a bundle update call in case the bundle install fails.

This fixes #66.

no-reply commented 7 years ago

I'm not sure that the failure on Ruby 2.3.1 has anything to do with these changes.

The changes here only fix #66 in a limited sense. There are definitely a bunch of other places where errors could be raised during test app creation, but the task will report success. These fixes allay my current problems.

cbeer commented 7 years ago

Thanks. I've dealt with the travis build (related to the new Rails 5.0.1 release), and included this change in v1.1.