cbeer / engine_cart

Rake tasks to generate test applications for Rails Engines
MIT License
18 stars 16 forks source link

Increment engine_cart stanza version (?) #81

Open dazza-codes opened 7 years ago

dazza-codes commented 7 years ago

For example, see the update PR in https://github.com/projecthydra-labs/hyrax/pull/1010/files and notice how some of the stanza content has changed but the stanza version has not changed.

dazza-codes commented 7 years ago

I need to check whether the hyrax stanza was hacked outside of engine_cart management.

dazza-codes commented 7 years ago

Looks like this is not an issue with engine_cart, because the stanza was hacked in hyrax at https://github.com/projecthydra-labs/hyrax/commit/8071e331a5d522c42dc104bbfaa7f64b7cb422c8

I guess that leaves open the question of how to override an engine-cart stanza without breaking the stanza versioning. Or we could just forget it :smiley: