search

cbeleites / hyperSpec

R package hyperSpec can now be found at https://github.com/r-hyperspec/hyperSpec
http://r-hyperspec.github.io/hyperSpec/
GNU General Public License v3.0
22 stars 11 forks source link

Delete unused files #317

Closed sangttruong closed 3 years ago

sangttruong commented 3 years ago

.factor2num(), .call.list(), and .split.dots() turn out to be a non-exported function. Thus, removing them is necessary to reduce complexity.

Resolve #278, Resolve #279, Resolve #280

GegznaV commented 3 years ago

@sangttruong

1) This PR is a duplicate of #315, so, please, address our comments and solve the original issues in #315 and not here. Did you base your new PR on the cbeleites/develop branch? 2) If you want to solve style issues that are non-breaing (add spaces, change = into <-, etc., other changes that are done with the styler package) then no extensive discussion is needed. But if changes are breaking, like a new function or argument names, then it is better to open a new issue before creating a PR.

In conclusion, firstly, fix the solution in #315. Then go to other tasks.

I you have any questions or need clarifications, please, do not hesitate to ask.