cbenning / fussel

A static photo gallery generator
https://github.com/cbenning/fussel
MIT License
255 stars 17 forks source link

Photo does not open with too many photos in album #80

Closed rda0 closed 1 year ago

rda0 commented 2 years ago

Starting with an album size of ~200 Photos, when opening a photo, the carousel view does not show the photo, just the UI controls. When clicking on X, the photo shortly flashes at you before switching back to the album view.

Up to ~100 photos works normal. I have not tested between 100 and 200.

I don't see any errors in the console.

Firefox: 102.0 Chrome: 103.0.5060.66 OS: Debian 11 Bullseye Python: 3.9.2 Node: v16.15.1 Fussel: 9545f5b

ElFishi commented 1 year ago

+1

swoertz commented 1 year ago

I also ran into this issue. As a workaround I was dividing my pictures into multiple albums, which is a bit unfortunate. I had a quick look at the problem and it seems like it is also connected to the size of the viewport. I noticed that when opening the developer tools of the browser, since the viewport got much smaller. When the height of the viewport was very small the picture showed up, however when the browser window is enlarged at some point the picture is moved to the left outside of the visible area. I am not sure at this point if this is potentially a problem in react-photo-gallery. However I couldn't see any related issues reported upstream for the react library. Unfortunately the project doesn't seem to be very active anymore, there hasn't been any commits/releases for some years.

cbenning commented 1 year ago

@swoertz are you able to test this using the v2 branch? It no longer uses react-photo-gallery. I generated al album the other night with > 300 photos and it seemed to work fine. Curious if it still suffers from this.

swoertz commented 1 year ago

@cbenning I've tried to generate a site on the v2 branch with the same input album where I was seeing the problem before and I couldn't reproduce the issue.

cbenning commented 1 year ago

So @swoertz just to confirm, the issue does not appear to happen with v2?

swoertz commented 1 year ago

Yes, that is correct. I wasn't able to reproduce the issue on v2.

cbenning commented 1 year ago

Thank you for verifying!