cbepx-me / Anbernic-H700-RG-xx-StockOS-Modification

Anbernic H700 Stock OS Modification
https://drive.google.com/drive/folders/1uwCkGX3H-K09pj0VbB6hkS8I0_qhzrGY?usp=sharing
321 stars 5 forks source link

Analogue snapping fix patch inclusion in cbepx-me #75

Open MarioFlying opened 3 months ago

MarioFlying commented 3 months ago

Is there any chance to see the fix for the RG40XX / RG35XX-H analogue snapping issue made by the GammaOS creator included in cbepx-me? That would be great.

The actual kernel fix: https://github.com/TheGammaSqueeze/40xx-kernel-decomp/releases

Demo: https://x.com/TheGammaSqueeze/status/1820112844949496101 https://x.com/TheGammaSqueeze/status/1819901665744666629

cbepx-me commented 3 months ago

Perhaps I will consider adding this fix at an appropriate time

JazzJohannes commented 1 month ago

To be quite honest, all he seems to have done is adjust settings in PPSSPP, that you can do yourself, I had the exact same results tweaking the emulator settings myself, there is nothing new there, and no kernel decompiling going on there. Besides the kernel has been open source for a while now, so you don't even need to decompile that.

MarioFlying commented 1 month ago

all he seems to have done is adjust settings in PPSSPP, that you can do yourself

This has already been discussed elsewhere. To clarify, tweaking PPSSPP settings helps with the dead zone and marginally with some of the snapping in PSP but it doesn't completely fix cardinal snapping.

Note that, once this kernel patch is applied, analogues start behaving correctly in every emulated system, not just on PSP but on PSX, N64, and ports, too. Once muOS Banana drops with this fix, video reports will pop up and this issue will be discussed more. I hope cbepx-me will adopt the fix as well.

the kernel has been open source

Anbernic never released sources, hence the need for the decompilation (and mods such as cbepx-me). H700 CFWs work would have been so much easier if devs had access to the source code. Maybe you're mistaken with other brands or way older Anbernic models.

This open issue is specifically about TheGammaSqueze's patch inclusion in cbepx-me anyway, so let's keep it about that and discuss all these things on forums instead👍🏻

JazzJohannes commented 1 month ago

all he seems to have done is adjust settings in PPSSPP, that you can do yourself

This has already been discussed elsewhere. To clarify, tweaking PPSSPP settings helps with the dead zone and marginally with some of the snapping in PSP but it doesn't completely fix cardinal snapping.

Gamma squeeze merely edited the dead-zone settings on the kernel, and not the kernel drivers for the joysticks themselves.

Note that, once this kernel patch is applied, analogues start behaving correctly in every emulated system, not just on PSP but on PSX, N64, and ports, too. Once muOS Banana drops with this fix, video reports will pop up and this issue will be discussed more. I hope cbepx-me will adopt the fix as well.

Also he didn't decompile it, that was already done here: https://git.sr.ht/~tokyovigilante/RG35XX_plus_docs/tree/main/sun50i-h700-anbernic-rg35xxph.dts

the kernel has been open source

Anbernic never released sources, hence the need for the decompilation (and mods such as cbepx-me). H700 CFWs work would have been so much easier if devs had access to the source code. Maybe you're mistaken with other brands or way older Anbernic models.

The mainline kernel is pretty much fully decompiled already: https://linux-sunxi.org/Anbernic_RG35XX_Plus

This open issue is specifically about TheGammaSqueze's patch inclusion in cbepx-me anyway, so let's keep it about that and discuss all these things on forums instead👍🏻

Well I would probably rather stick to stock or cbepx-me mod stock as well then, instead of going on a tangent of MuleOS banana lol hahaha 👎

MarioFlying commented 1 month ago

Gamma squeeze merely edited the dead-zone settings / Also he didn't decompile it

As long as it works, everybody's fine with it.

I would probably rather stick

Not relevant. People subscribed to the issue get notified, let's keep this related to the issue at hand. This is going to be my last reply