search

cberner / fuser

Filesystem in Userspace (FUSE) for Rust
MIT License
836 stars 114 forks source link

Ensure that Filesystem.destroy() is always called #154

Closed cberner closed 3 years ago

cberner commented 3 years ago

libfuse uses the same workaround of calling .destroy() if the kernel never delivers the DESTROY message

Fixes #153

boulos commented 3 years ago

This is also a breaking API change to destroy, right? Can't you manufacture a Request instead?

cberner commented 3 years ago

This is also a breaking API change to destroy, right? Can't you manufacture a Request instead?

It is yes, but updating should be easy for people. I don't like the idea of manufacturing a request, because there would be no way to tell whether the data in the request was real then

edit It looks like libfuse doesn't pass the request parameter at all, actually. Maybe I should just remove it?

boulos commented 3 years ago

That's fine. Maybe note it in your changelog as well.