Warning and comment to clarify AutoUnmount behavior

cberner / fuser

Filesystem in Userspace (FUSE) for Rust

MIT License

836 stars 114 forks source link

Warning and comment to clarify AutoUnmount behavior #180

Closed mgree closed 3 years ago

mgree commented 3 years ago

I was caught out by a change in how options are treated in 0.9.1: if you set AutoUnmount and neither AllowRoot or AllowOther are set, then AllowOther is getting automatically added. If your /etc/fuse.conf doesn't permit AllowOther, the mount will fail without much information. See the latter half of #153, after it was closed.

This PR adds a warning when AllowOther is added and a comment to the options datatype, in the hopes of saving others some trouble.

cberner commented 3 years ago

Could you run the formatter to resolve that CI failure?

mgree commented 3 years ago

Oops! Sorry about that. 🤭

cberner commented 3 years ago

Merged. thanks!