search

cberner / raptorq

Rust implementation of RaptorQ (RFC6330)
Apache License 2.0
296 stars 49 forks source link

CPython wrapper #26

Closed felixschorer closed 4 years ago

felixschorer commented 4 years ago

I have written a small wrapper to compile the library to a native CPython module. Currently, it only features the high level Encoder/Decoder API. The code is part of that repository.

Shall I open a PR to integrate the code into this repository?

cberner commented 4 years ago

I'm happy to integrate it. However, I'm not sure how to. It looks like your wrapper requires changing the crate-type to "cdylib". Is there a way to make that conditional on a feature flag?

felixschorer commented 4 years ago

I would have added a second crate (i.e. python/cargo.toml) which references the main crate.

cberner commented 4 years ago

Ah, that makes sense. Sure, I'd be happy to merge a PR that integrates it as another crate