search

cberner / raptorq

Rust implementation of RaptorQ (RFC6330)
Apache License 2.0
285 stars 47 forks source link

Remove ad-hoc serialization code #28

Closed ckaran closed 4 years ago

ckaran commented 4 years ago

PR #27 ensures that most of the structs in the crate have serde::{Serialize, Deserialize} implemented on them. That means that any ad-hoc serialization code (such as ObjectTransmissionInformation::{serialize(), deserialize()}) are no longer necessary, and may actually be detrimental in the long run. Although it will be a breaking change requiring a major version bump, it may be a good idea to remove the ad-hoc code.

cberner commented 4 years ago

Going to close this. Those methods are necessary because they use the RFC6330 serialization format