search

cberner / raptorq

Rust implementation of RaptorQ (RFC6330)
Apache License 2.0
296 stars 49 forks source link

[question]About the recovery strategies #62

Closed ycopy closed 4 years ago

ycopy commented 4 years ago

Hi Cberner, 

It seems that your implementation of recovery strategies is for devices that have enough RAM, (please correct me if I am wrong).
According to RFC6330 4.4.3 's last paragraph, There is an alternative approach for RAM limited devices, what do you think of it ? 

Have a nice day. thanks in advance.
cberner commented 4 years ago

Yes, that's how Encoder works, since I didn't want it to manage disk storage. If you have an environment with limited RAM, you probably want to use the SourceBlockDecoder interface. You can use that to decode a single block at a time

ycopy commented 4 years ago

I get the idea, thank you.

BTW, I get a little performance up by removing the get_row_iter.clone operation in firstPhaseRowSelectionStats::first_phase_swap_columns_substep, It seems safe to remove it, But I'm not very sure.